Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump DDS to 3.5.13 #1

Closed
wants to merge 1 commit into from
Closed

Bump DDS to 3.5.13 #1

wants to merge 1 commit into from

Conversation

AndreyLebedev
Copy link

  • Also temporarily comment out bottles which will be generated later

@dennisklein
Copy link
Member

hmm, does this work for you? for me the patch does not work for 3.5.13

@AndreyLebedev
Bump DDS to 3.5.13
6c481d0 
* Also temporarily comment out bottles which will be generated later
* Also disable patch
@AndreyLebedev AndreyLebedev marked this pull request as draft June 10, 2021 12:35
@AndreyLebedev
Copy link
Author

sorry, no it doesn't, it fails to apply a patch, need more time to get it right

@dennisklein
Copy link
Member

It is this patch: FairRootGroup/DDS#354. Needs just a rebase on current master. If it is not merged upstream any time soon, we can keep hosting the patch in the FairSoft repo, we have the patches/ subdirectory especially for such situations, see https://github.com/FairRootGroup/FairSoft/tree/master/patches.

@dennisklein
Copy link
Member

@AndreyLebedev So, the DDS Formula is now bumped to 3.5.14 and installed on citmac001 and witmac007, but when running the FairRootGroup/ODC#18 test suite, it complains about

test 23
      Start 23: odc_core_lib::topology/construction

23: Test command: /Users/alfaci/alfaci/workspace/FairRootGroup_ODC_PR-18/build/tests/odc_core_lib-tests "--log_level=message" "--run_test=topology/construction" "--" "--topo-file" "/Users/alfaci/alfaci/workspace/FairRootGroup_ODC_PR-18/build/install/share/odc/odc_core_lib-tests-topo.xml"
23: Environment variables: 
23:  DYLD_LIBRARY_PATH=/Users/alfaci/alfaci/workspace/FairRootGroup_ODC_PR-18/build/install/lib:$DYLD_LIBRARY_PATH
23:  PATH=/Users/alfaci/alfaci/workspace/FairRootGroup_ODC_PR-18/build/install/bin:$PATH
23: Test timeout computed to be: 10
23: Running 1 test case...
23: Creating new worker package...
23: WN Package Tool: failed; STDOUT:; STDERR: env: bash: No such file or directory
23: 
 1/33 Test #28: odc_core_lib::topology/set_properties .......................................***Timeout  10.03 sec
Running 1 test case...
Creating new worker package...
WN Package Tool: failed; STDOUT:; STDERR: env: bash: No such file or directory

Not really sure if this is a problem of the DDS installation or if I am missing setting something up.

@dennisklein
Copy link
Member

Nevermind, the moment I posted this, I realized that I have missed the ENV in the ctest environment variable declaration which was there before my change... works now :P

@dennisklein
Copy link
Member

closing because obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreyLebedev @dennisklein